Server: improved even registration mechanism #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server now relies on a std::promise to check the success of a request to register for events instead of passively listening for a QSignal to come back. This change brings two improvements: - It fixes an issue with multiple clients, where all the clients were being notified when any of them tried to register, causing a warning message to be printed. - The Stream client is notified also if the request is not handled at all by the Server application (broken promise).
hernando
reviewed
Mar 21, 2017
hernando
approved these changes
Mar 21, 2017
| { | ||
| _registeredToEvents = future.get(); | ||
| } | ||
| catch (...) |
There was a problem hiding this comment.
catch broken promise instead of anything?
There was a problem hiding this comment.
I find it safer to catch everything in case the promise holds an exception instead of a value. In all cases, it is reasonable to assume that if an exception happens then the registration must have failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server now relies on a std::promise to check the success of a request to register for events instead of passively listening for a QSignal to come back. This change brings two improvements: