Stereo streaming accepts side-by-side images as input #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
reviewed
Apr 21, 2017
deflect/ImageSegmenter.cpp
Outdated
| unsigned int uniformSegmentHeight = image.height; | ||
| // create copy of segments for right view | ||
| auto segmentsRight = segments; | ||
| for (auto&& segment : segmentsRight) |
There was a problem hiding this comment.
it's more a 'real' reference here, no? modifying a temporary at least looks wrong.
There was a problem hiding this comment.
Yeah, in this case auto&& it's not an rvalue reference but a universal reference... I amended it to avoid confusion. Using auto& or auto&& make no difference here, but I let you google about it.
tribal-tec
approved these changes
Apr 21, 2017
This is useful for applications like Brayns which render natively in side-by-side format. Splitting the image into a left and right part during the tiling process is more optimal and user-friendly than asking the application to do it and make two send() calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for applications like Brayns which render natively in
side-by-side format. Splitting the image into a left and right part
during the tiling process is more optimal and user-friendly than
asking the application to do it and make two send() calls.