Performance improvements for sending small images (tested with 64x64) #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dnachbaur
commented
Jul 3, 2017
dnachbaur
commented
- directly compress them in the call thread
- keep JPEG out buffer allocated to save one memory allocation
rdumusc
reviewed
Jul 3, 2017
deflect/ImageJpegCompressor.h
Outdated
|
|
||
| private: | ||
| tjhandle _tjHandle; | ||
| std::vector<unsigned char> tjJpegBuf; |
deflect/StreamSendWorker.cpp
Outdated
| return promise.get_future(); | ||
| } | ||
|
|
||
| if (image.width <= 64 && image.height <= 64 && |
deflect/StreamSendWorker.cpp
Outdated
| [this, segment] { return _sendSegment(segment); }}; | ||
| if (finish) | ||
| tasks.emplace_back([this] { return _sendFinish(); }); | ||
| return _enqueueRequest(std::move(tasks)); |
There was a problem hiding this comment.
these last 3 lines are the same as the normal case below, reuse them with an if/else for setting tasks?
- directly compress them in the call thread - keep JPEG out buffer allocated to save one memory allocation
|
updated |
rdumusc
approved these changes
Jul 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.