Add deflect::Observer which can be used to only receive events w/o the need to send images #175
Conversation
…e need to send images
dnachbaur
changed the title
| class StreamPrivate; | ||
|
|
||
| /** | ||
| */ |
There was a problem hiding this comment.
empty docstring
adjust documentation in this file a bit, explaining how to use an Observer and replacing "stream" with "observer" where applicable
| { | ||
| } | ||
|
|
||
| FrameDispatcher* frameDispatcher; |
deflect/StreamSendWorker.cpp
Outdated
| Stream::Future StreamSendWorker::enqueueObserverClose() | ||
| { | ||
| return _enqueueRequest( | ||
| {[this] { return _send(MESSAGE_TYPE_OBSERVER_QUIT, {}); }}); |
There was a problem hiding this comment.
do we need a separate MESSAGE_TYPE_OBSERVER_QUIT? Couldn't we just use the normal MESSAGE_TYPE_QUIT?
There was a problem hiding this comment.
Couldn't find a satisfying solution to make that work. Now it's clearer having two messages indicating the the source is a observer.
deflect/ServerWorker.cpp
Outdated
| if (!_streamId.isEmpty()) | ||
| { | ||
| emit removeStreamSource(_streamId, _sourceId); | ||
| emit removeObserver(_streamId, _sourceId); |
There was a problem hiding this comment.
look like a bit brute force, maybe remember the stream type and emit just the correct signal?
There was a problem hiding this comment.
hmm, if the type is remembered, the upper comment could also be resolved. I'll have a look
|
|
||
| cmake_minimum_required(VERSION 3.1 FATAL_ERROR) | ||
| project(Deflect VERSION 0.13.1) | ||
| project(Deflect VERSION 0.14.0) |
There was a problem hiding this comment.
I suspect the split of Stream in Observer + Stream to break the ABI as well, no?
There was a problem hiding this comment.
probably yes. Will bump for safety.
|
I'm actually wondering what the version tag corresponds to the CMakeLists.txt version. 0.13 == 1.3? But there's a 1.5 version tag in Observer.h as well... |
No description provided.