Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow for auto tagging and github releasing #30

Merged
merged 12 commits into from
Aug 4, 2023
Merged

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Aug 3, 2023

No description provided.

WITH_V: false
DEFAULT_BUMP: patch

- name: Get and store tag from 'Bump version and push tag' step

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very important, but you don't have any 'Bump version and push tag' step, which can be misleading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh thanks let me update that text

@@ -7,6 +7,7 @@ on:
push:
branches: [ "main" ]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be called twice on push to main branch. Once with this, and once with the workflow call

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh right, I can remove the push branches main part then, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes ;)

@wvangeit
Copy link
Contributor

wvangeit commented Aug 3, 2023

Actually, can you add a .zenodo.json file with the exact author list of the paper.

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need .zenodo.json file

"description": "Repository for reproducing the work described at the 'A universal workflow for creation, validation and generalization of detailed neuronal models' publication.",
"creators": [
{
"affiliation": "Blue Brain Project, EPFL",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the orcid ids

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I get them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of them are mentioned in other zenodo files of our packages. And for others you have to search for the person here: https://orcid.org/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, all 9 are added

@anilbey anilbey merged commit e7c34ef into main Aug 4, 2023
@anilbey anilbey deleted the release branch October 10, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants