-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release workflow for auto tagging and github releasing #30
Conversation
.github/workflows/release.yml
Outdated
WITH_V: false | ||
DEFAULT_BUMP: patch | ||
|
||
- name: Get and store tag from 'Bump version and push tag' step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very important, but you don't have any 'Bump version and push tag' step, which can be misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh thanks let me update that text
.github/workflows/python-app.yml
Outdated
@@ -7,6 +7,7 @@ on: | |||
push: | |||
branches: [ "main" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be called twice on push to main branch. Once with this, and once with the workflow call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh right, I can remove the push branches main part then, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes ;)
Actually, can you add a .zenodo.json file with the exact author list of the paper. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need .zenodo.json file
"description": "Repository for reproducing the work described at the 'A universal workflow for creation, validation and generalization of detailed neuronal models' publication.", | ||
"creators": [ | ||
{ | ||
"affiliation": "Blue Brain Project, EPFL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the orcid ids
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I get them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of them are mentioned in other zenodo files of our packages. And for others you have to search for the person here: https://orcid.org/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, all 9 are added
No description provided.