Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci: separate build-wheels from publish #370

Merged
merged 8 commits into from
Feb 21, 2024
Merged

Ci: separate build-wheels from publish #370

merged 8 commits into from
Feb 21, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Feb 20, 2024

Description

Separates build-wheels to call it before pull-requests as well as building before publishing.
Changes to C++ codebase sometimes impact wheel building and that is better tested before PR is merged.

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@anilbey anilbey marked this pull request as ready for review February 20, 2024 17:08
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also change the name at 1st line of the publish.yml file to be consistent

@anilbey
Copy link
Contributor Author

anilbey commented Feb 21, 2024

you can also change the name at 1st line of the publish.yml file to be consistent

Done

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@anilbey anilbey merged commit 034a377 into master Feb 21, 2024
20 checks passed
@anilbey anilbey deleted the ci branch February 21, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants