Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes: AP_end_indices, AP_fall_indices, depolarized_base #374

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Bug fixes: AP_end_indices, AP_fall_indices, depolarized_base #374

merged 8 commits into from
Apr 8, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Mar 28, 2024 •
edited
Loading

Fixed edge case bugs in AP_end_indices, AP_fall_indices and depolarized_base to prevent segmentation faults

@ilkilic ilkilic self-assigned this Mar 28, 2024
@ilkilic ilkilic requested a review from anilbey April 2, 2024 08:39
anilbey
anilbey reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! If possible, could you add a test where these apendi.size() and apbi.size() are not equal?

@ilkilic ilkilic changed the title Fix index out of bounds error in __depolarized_base Bug fixes: AP_end_indices, AP_fall_indices, depolarized_base Apr 8, 2024
@ilkilic
Copy link
Collaborator Author

ilkilic commented Apr 8, 2024

I have also fixed AP_end_indices and AP_fall_indices to prevent segmentation with outlier data

anilbey
anilbey reviewed Apr 8, 2024
View reviewed changes
tests/test_basic.py Outdated Show resolved Hide resolved
anilbey
anilbey approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 critical bugs are fixed. Amazing!

@ilkilic ilkilic merged commit b7bec41 into master Apr 8, 2024
20 checks passed
@ilkilic ilkilic deleted the fix-oob-depolarized_base branch April 8, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilbey anilbey anilbey approved these changes

Assignees

@ilkilic ilkilic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilkilic @anilbey