Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace deprecated api functions usage within efel #375

Merged
merged 10 commits into from
Apr 19, 2024
Merged

replace deprecated api functions usage within efel #375

merged 10 commits into from
Apr 19, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Apr 4, 2024 •
edited
Loading

Description

  • Replace the usage of deprecated api function calls within efel.
  • Inform the type checker on get_feature_values' 2 different return type overloads.

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@anilbey anilbey changed the title go through efel api/settings usage replace deprecated api functions usage within efel Apr 19, 2024
@anilbey anilbey marked this pull request as ready for review April 19, 2024 14:14
AurelienJaquier
AurelienJaquier approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@anilbey
Copy link
Contributor Author

anilbey commented Apr 19, 2024

Cool, merging. This should reduce the amount of deprecation warnings in our downstream workflows also.

@anilbey anilbey merged commit 2890f80 into master Apr 19, 2024
20 checks passed
@anilbey anilbey deleted the settings branch April 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienJaquier AurelienJaquier AurelienJaquier approved these changes

@ilkilic ilkilic Awaiting requested review from ilkilic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anilbey @AurelienJaquier