Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganised efeature documentation #382

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

AurelienJaquier
Copy link
Collaborator

Description

renamed Voltage features -> Subthreshold features

moved from Python features:
to Spike event features: spikes_per_burst, spikes_per_burst_diff, spikes_in_burst1_burst2_diff, spikes_in_burst1_burstlast_diff

to Spike shape features: initburst_sahp, initburst_sahp_ssse, initburst_sahp_vb, phaseslope_max

I did not move depol_block_bool or impedance, because they don't fit in spike-related features, neither in subthreshold features

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (2cddd26) to head (8814c41).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files          36       36           
  Lines        6278     6278           
  Branches     2033     2033           
=======================================
  Hits         5759     5759           
  Misses        266      266           
  Partials      253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@AurelienJaquier AurelienJaquier merged commit 69f1c1b into BlueBrain:master Apr 26, 2024
20 checks passed
@AurelienJaquier AurelienJaquier deleted the docs-update branch April 26, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants