-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pdf documentation #412
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 91.73% 91.51% -0.22%
==========================================
Files 36 39 +3
Lines 6278 7744 +1466
Branches 2033 2366 +333
==========================================
+ Hits 5759 7087 +1328
- Misses 266 316 +50
- Partials 253 341 +88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AurelienJaquier ! Could you also update the PR description and Changelog to mention all the indices features added?:
added to features docs: check_ais_initiation, bpap_attenuation, all indices features
Users might misunderstand that the "all indices features" is one efel feature :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
There was no substantial information in the pdf that were not already present in the official doc. The official doc was based on the pdf I believe, so many things were similar. But since the doc has been kept up to date, it is actually more detailed than the pdf, exception to the algorithm descriptions.
Also did:
Checklist: