add "power" matching #147
Merged
add "power" matching #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matz-e you're welcome to read this, I still have to up the coverage, and fix some of the build checks. |
matz-e
reviewed
Jun 8, 2021
src/node_sets.cpp
Outdated
| case Op::regex: | ||
| return "$regex"; | ||
| default: | ||
| throw SonataError("Not Implemented NodeSetBasicOperator"); |
There was a problem hiding this comment.
I let clang-format work its magic
There was a problem hiding this comment.
I meant with fmt::format, sorry, not very clear.
matz-e
reviewed
Jun 8, 2021
use vector<bool> as suggested by Matthias
matz-e
reviewed
Jun 15, 2021
python/generated/docstrings.h
Outdated
| @@ -75,6 +75,8 @@ Note: This does not match dynamics_params datasets)doc"; | |||
|
|
|||
| static const char *__doc_bbp_sonata_NodePopulation_matchAttributeValues_2 = R"doc(Like matchAttributeValues, but for vectors of values to match)doc"; | |||
|
|
|||
| static const char *__doc_bbp_sonata_NodePopulation_regexMatch = R"doc()doc"; | |||
There was a problem hiding this comment.
No documentation?
Also, should we explicitly mark these as extensions to the SONATA™ spec? Or is there an upstream PR amending this situation already?
There was a problem hiding this comment.
thanks, need to add the doc...I will do that.
I think it's worth doing a PR upstream to the docs, at least so ppl can read about the feature
matz-e
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.