Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump HighFive to v2.7.1 #278

Merged
merged 2 commits into from
Jun 23, 2023
Merged

bump HighFive to v2.7.1 #278

merged 2 commits into from
Jun 23, 2023

Conversation

mgeplf
Copy link
Contributor

@mgeplf mgeplf commented Jun 23, 2023

No description provided.

@mgeplf mgeplf requested review from matz-e and 1uc June 23, 2023 08:15
@mgeplf mgeplf requested a review from WeinaJi June 23, 2023 09:26
@mgeplf
Copy link
Contributor Author

mgeplf commented Jun 23, 2023

Apparently James needs a new release of libsonata so that the metadata field is available. I'd prefer if HighFive was using a tagged version; the tests pass; but I'm not knowledgealbe about the internals enough to know if this is safe.

Can someone look?

Copy link
Collaborator

@WeinaJi WeinaJi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the neurodamus side. I've built neurodamus with this branch and the simulation works as usual.

@WeinaJi WeinaJi requested a review from alkino June 23, 2023 10:09
@WeinaJi
Copy link
Collaborator

WeinaJi commented Jun 23, 2023

Tag @alkino for review

@mgeplf mgeplf merged commit e0086d4 into master Jun 23, 2023
@mgeplf mgeplf deleted the bump-highfive-to-2.7.1 branch June 23, 2023 11:03
@mgeplf
Copy link
Contributor Author

mgeplf commented Jun 23, 2023

Great, thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants