Use RawIndex = std::vector<std::array<.., 2>>.
#294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memory layout of an `std::vector<std::array<...>>` is better than `std::vector<std::vector<...>>`. This allows HighFive to avoid numerous allocations and copies.
1uc
force-pushed
the
1uc/improve-RawIndex
branch
from
de59161
to
2781f16
Compare
matz-e
approved these changes
Oct 18, 2023
mgeplf
approved these changes
Oct 19, 2023
|
very nice, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory layout of an
std::vector<std::array<...>>is better thanstd::vector<std::vector<...>>. This allows HighFive to avoid numerous allocations and copies. Additionally, I feel it's simpler because it avoid the ambiguity of rows of differing length, when in fact theRawIndexseems to be a vector of ranges.