Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling coverage for 'Debug'. #299

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Oct 25, 2023

If the user specifies -DSONATA_ENABLE_COVERAGE then that choice is respected. If no choice is made coverage is On for Debug build; and Off otherwise.

Turning off coverage is useful, if one doesn't have lcov but still wants a debug build.

@1uc 1uc marked this pull request as ready for review October 25, 2023 13:53
@1uc 1uc changed the title Allow disabling coverage an 'Debug'. Allow disabling coverage for 'Debug'. Nov 2, 2023
If the user specifies `-DSONATA_ENABLE_COVERAGE` then that choice is
respected. If no choice is made coverage is `On` for `Debug` build; and
`Off` otherwise.

Turning off coverage is useful, if one doesn't have `lcov` but still
wants a debug build.
@joni-herttuainen joni-herttuainen merged commit 6da4886 into master Nov 3, 2023
29 checks passed
@joni-herttuainen joni-herttuainen deleted the 1uc/optional-coverage branch November 3, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants