Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor _readSelection. #315

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Refactor _readSelection. #315

merged 1 commit into from
Nov 29, 2023

Commits on Nov 27, 2023

  1. Refactor _readSelection.

    This commit refactors `_readSelection` in such a manner that:
      1. Canonical selections don't require post-read shuffling.
      2. The reading of the dataset is moved to a separate function.
    
    As a consequence, there's no need for an optimization for `std::string`, since
    those only mattern when reading from the `"@library"`, which should only happen
    indirectly. Hence, we free to ensure that those are always canonical.
    1uc committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a6915c6 View commit details
    Browse the repository at this point in the history