Fix incompatibility issues with manylinux1 platform #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- manylinux1 platform provides gcc 4.8.1 for wider compatibility - gcc 4.8.1 is first gnu compiler supporting `almost all` C++11 except that it lacks const_iterator overload for std::vector::erase and std::vector::insert - in this PR we introduce const_iter_cast thar turns const iterator into non-const-iterator with minimal changes to the code base - change the compatibility to gcc 4.8.2 for cmake as well as json library - change pybind11::literals::operator""_a to namespace pybind11::literals as documented in https://pybind11.readthedocs.io/en/stable/basics.html#keyword-arguments fixes #319
pramodk
commented
May 5, 2020
ohm314
reviewed
May 5, 2020
Co-authored-by: Omar Awile <omar.awile@epfl.ch>
|
checking jenkins looks like there is some code left for debugging that prints the pythonpath for every test... |
that might be just some old builds. I dont see any debug code into latest commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We would like to ship nmodl with NEURON manylinux1 wheel during upcoming release 8.0
Changes
almost allC++11except that it lacks
const_iteratoroverload for std::vector::eraseand std::vector::insert
into non-const-iterator to have minimal changes to the code base
pybind11::literals::operator""_atonamespace pybind11::literalsas documented in https://pybind11.readthedocs.io/en/stable/basics.html#keyword-arguments
fixes #319
Considerations