Extended support for binary ops and refactoring #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
pramodk
reviewed
Jan 8, 2021
pramodk
approved these changes
Jan 10, 2021
There was a problem hiding this comment.
@georgemitenkov : above suggested change you can do in separate PR if you would like.
Once you fix clang-format, this is good to merge.
error:improper C/C++ file formatting: /jenkins/06/workspace/hpc.nmodl/platform/bb5/src/codegen/llvm/codegen_llvm_visitor.hpp
|
@pramodk I made the change here straight away - it is just a couple of lines. Now we can pass an extra flag to the visitor: I also altered one test to check that IR is generated correctly for floats. |
pramodk
pushed a commit
that referenced
this pull request
Feb 23, 2021
* Added more bin ops and refactored code
- Now, there are code generation functions for all comparison
and logical operators.
- Code generation functions are now split based on the expression "type"
(assignment, arithmetic, comparison, logical). Moreover, the lhs and rhs
expression results can be both double and integer. This is important for
control flow code generation and for the new AST node CodegenVarType.
* Added support for NOT op
* Added default type flag to switch between float and double
* Added tests for single precision
* Renames LLVM test file to codegen_llvm_ir.cpp to follow convention.
* NOTE : Tests for new operators will be added when the first control
flow node (most likely FOR node) will land.
fixes #453
pramodk
pushed a commit
that referenced
this pull request
May 8, 2021
* Added more bin ops and refactored code
- Now, there are code generation functions for all comparison
and logical operators.
- Code generation functions are now split based on the expression "type"
(assignment, arithmetic, comparison, logical). Moreover, the lhs and rhs
expression results can be both double and integer. This is important for
control flow code generation and for the new AST node CodegenVarType.
* Added support for NOT op
* Added default type flag to switch between float and double
* Added tests for single precision
* Renames LLVM test file to codegen_llvm_ir.cpp to follow convention.
* NOTE : Tests for new operators will be added when the first control
flow node (most likely FOR node) will land.
fixes #453
pramodk
pushed a commit
that referenced
this pull request
Mar 8, 2022
* Added more bin ops and refactored code
- Now, there are code generation functions for all comparison
and logical operators.
- Code generation functions are now split based on the expression "type"
(assignment, arithmetic, comparison, logical). Moreover, the lhs and rhs
expression results can be both double and integer. This is important for
control flow code generation and for the new AST node CodegenVarType.
* Added support for NOT op
* Added default type flag to switch between float and double
* Added tests for single precision
* Renames LLVM test file to codegen_llvm_ir.cpp to follow convention.
* NOTE : Tests for new operators will be added when the first control
flow node (most likely FOR node) will land.
fixes #453
iomaganaris
pushed a commit
that referenced
this pull request
May 10, 2022
* Added more bin ops and refactored code
- Now, there are code generation functions for all comparison
and logical operators.
- Code generation functions are now split based on the expression "type"
(assignment, arithmetic, comparison, logical). Moreover, the lhs and rhs
expression results can be both double and integer. This is important for
control flow code generation and for the new AST node CodegenVarType.
* Added support for NOT op
* Added default type flag to switch between float and double
* Added tests for single precision
* Renames LLVM test file to codegen_llvm_ir.cpp to follow convention.
* NOTE : Tests for new operators will be added when the first control
flow node (most likely FOR node) will land.
fixes #453
iomaganaris
pushed a commit
that referenced
this pull request
May 12, 2022
* Added more bin ops and refactored code
- Now, there are code generation functions for all comparison
and logical operators.
- Code generation functions are now split based on the expression "type"
(assignment, arithmetic, comparison, logical). Moreover, the lhs and rhs
expression results can be both double and integer. This is important for
control flow code generation and for the new AST node CodegenVarType.
* Added support for NOT op
* Added default type flag to switch between float and double
* Added tests for single precision
* Renames LLVM test file to codegen_llvm_ir.cpp to follow convention.
* NOTE : Tests for new operators will be added when the first control
flow node (most likely FOR node) will land.
fixes #453
iomaganaris
pushed a commit
that referenced
this pull request
Sep 15, 2022
* Added more bin ops and refactored code
- Now, there are code generation functions for all comparison
and logical operators.
- Code generation functions are now split based on the expression "type"
(assignment, arithmetic, comparison, logical). Moreover, the lhs and rhs
expression results can be both double and integer. This is important for
control flow code generation and for the new AST node CodegenVarType.
* Added support for NOT op
* Added default type flag to switch between float and double
* Added tests for single precision
* Renames LLVM test file to codegen_llvm_ir.cpp to follow convention.
* NOTE : Tests for new operators will be added when the first control
flow node (most likely FOR node) will land.
fixes #453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 2 issues:
Now, there are code generation functions for all comparison and logical operators. Code generation functions are now split based on the expression "type" (assignment, arithmetic, comparison, logical). Moreover, the lhs and rhs expression results can be both double and integer. This is important for control flow code generation and for the new AST node
CodegenVarType.Tests for new operators will be added when the first control flow node (most likely FOR node) will land.
codegen_llvm_ir.cppto follow convention.fixes #453