Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for TABLE statements in FUNCTION blocks #913

Merged
merged 6 commits into from
Aug 24, 2022
Merged

Support for TABLE statements in FUNCTION blocks #913

merged 6 commits into from
Aug 24, 2022

Conversation

alkino
Copy link
Member

@alkino alkino commented Aug 23, 2022 •
edited by pramodk
Loading

In mod2c a table works really differently from a function or from a procedure.
For example, TABLE in FUNCTION has an implicit variable name same as the function name.
In this PR we implement TABLE support for function same as mod2c.

Nicolas Cornu added 3 commits August 23, 2022 11:16
Add a check for table name list in TABLE statement
aa30b40 
In a function, the table statement is on the variable that got the name of the function.
In procedure such mechanisms does not exists and so you should give at least
one name in the list.
Fix table inside function
6a57715
Creation of t_<function_name> for functions with table
7765b8a
@alkino alkino marked this pull request as ready for review August 23, 2022 09:35
@alkino alkino linked an issue Aug 23, 2022 that may be closed by this pull request
Issue with TABLE statement definitions #771
Closed
1 task
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #70775 (:white_check_mark:) have been uploaded here!

Status and direct links:

@BlueBrain BlueBrain deleted a comment from bbpbuildbot Aug 23, 2022
@BlueBrain BlueBrain deleted a comment from bbpbuildbot Aug 23, 2022
@pramodk pramodk changed the title Rework table for functions Support for TABLE statements in FUNCTION blocks Aug 24, 2022
pramodk
pramodk approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@pramodk pramodk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes LGTM.

We will need some validation/integration test but that we could do in #888.

Before merging, we should check conflict aspects with #904! cc: @olupton

@alkino alkino merged commit 047811a into master Aug 24, 2022
@alkino alkino deleted the check_table_list_of_name branch August 24, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with TABLE statement definitions
3 participants
@alkino @bbpbuildbot @pramodk