add tests for nodes multi group

BlueBrain · Jul 21, 2020 · 4fcd102 · 4fcd102
1 parent aa97ba5
commit 4fcd102
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 2 deletions.
diff --git a/tests/data/circuit_config.json b/tests/data/circuit_config.json
@@ -13,7 +13,7 @@
     "nodes": [
       {
         "nodes_file": "$NETWORK_DIR/nodes.h5",
-        "node_types_file": null
+        "node_types_file": "$NETWORK_DIR/node_types.csv"
       }
     ],
     "edges": [

diff --git a/tests/data/node_types.csv b/tests/data/node_types.csv
@@ -0,0 +1,2 @@
+node_type_id model_processing
+1 perisomatic
diff --git a/tests/data/nodes.h5 b/tests/data/nodes.h5
diff --git a/tests/test_circuit.py b/tests/test_circuit.py
@@ -18,7 +18,7 @@ def test_all():
             circuit.config['networks']['nodes'][0] ==
             {
                 'nodes_file': str(TEST_DATA_DIR / 'nodes.h5'),
-                'node_types_file': None,
+                'node_types_file': str(TEST_DATA_DIR / 'node_types.csv'),
             }
     )
     assert isinstance(circuit.nodes, dict)

diff --git a/tests/test_circuit_validation.py b/tests/test_circuit_validation.py
@@ -37,6 +37,12 @@ def test_ok_circuit():
     errors = test_module.validate(str(TEST_DATA_DIR / 'circuit_config.json'))
     assert errors == []
 
+    with copy_circuit() as (_, config_copy_path):
+        with edit_config(config_copy_path) as config:
+            config['networks']['nodes'][0]['node_types_file'] = None
+        errors = test_module.validate(config_copy_path)
+        assert errors == []
+
 
 def test_no_config_components():
     with copy_circuit() as (_, config_copy_path):
@@ -163,6 +169,17 @@ def test_no_required_node_multi_group_datasets():
                                     format(nodes_file, [ds]))]
 
 
+def test_nodes_multi_group_wrong_group_id():
+    with copy_circuit() as (circuit_copy_path, config_copy_path):
+        nodes_file = circuit_copy_path / 'nodes.h5'
+        with h5py.File(nodes_file, 'r+') as h5f:
+            h5f.copy('nodes/default/0', 'nodes/default/1')
+            h5f['nodes/default/node_group_id'][-1] = 2
+        errors = test_module.validate(str(config_copy_path))
+        assert errors == [Error(Error.FATAL, 'Population /nodes/default of {} misses group(s): {}'.
+                                format(nodes_file, {2}))]
+
+
 def test_no_required_node_group_datasets():
     required_datasets = ['model_template', 'model_type']
     with copy_circuit() as (circuit_copy_path, config_copy_path):