Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scanMessage Implementation #46

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JUSTINMKAUFMAN
Copy link

@JUSTINMKAUFMAN JUSTINMKAUFMAN commented Dec 31, 2024

The IMDDController.sharedInstance.scanMessage method, which is used to detect rich message content in text, is currently broken.

There are 3 problems:

  1. The completionBlock signature has changed and now takes 3 parameters (not 2).
  2. The scanMessage method now mutates the message you pass it directly, so you don't want to actually touch any of the completionBlock arguments like the code currently does.
  3. The call to send the message needs to be dispatched to the main thread to avoid crashing when exiting the completionBlock.

Tested on 2 instances running:
[1] macOS 15.1.1
[2] macOS 15.2

Both instances serve high message volume (i.e. thousands of messages in/out across iMessage/SMS/RCS handles) and both have been working smoothly since yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant