-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Fixes algorithm to compute shape factors from Triangle geometry #1157
Draft
imikejackson
wants to merge
11
commits into
BlueQuartzSoftware:develop
Choose a base branch
from
imikejackson:topic/compute_triangle_shapes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ENH: Fixes algorithm to compute shape factors from Triangle geometry #1157
imikejackson
wants to merge
11
commits into
BlueQuartzSoftware:develop
from
imikejackson:topic/compute_triangle_shapes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
force-pushed
the
topic/compute_triangle_shapes
branch
2 times, most recently
from
December 7, 2024 04:15
2958ada
to
a9617d5
Compare
imikejackson
force-pushed
the
topic/compute_triangle_shapes
branch
from
December 17, 2024 19:36
391e442
to
9b00ecb
Compare
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Axis and EulerAxis are not verified yet. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
All values are validated against the voxel generated results and the theoretical values. Theoretical values taken from paper from De Graef, Simmons, et. al. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
topic/compute_triangle_shapes
branch
from
December 27, 2024 18:03
24db283
to
db939dd
Compare
…onsolidation, further comment documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.