[WIP] BUG: Sets Face Label for virtual boundary to -1 in SurfaceNetsFilter #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
imikejackson
commented
Dec 6, 2024
imikejackson
commented
- This makes the value consistent with QuickMesh
- Added documentation on the pros, cons and Face Labels for this filter.
nyoungbq
approved these changes
Dec 6, 2024
imikejackson
force-pushed
the
topic/surface_nets_virtual_boundary_value
branch
from
c39efd1 to
c33ee50
Compare
- This makes the value consistent with QuickMesh - Added documentation on the pros, cons and Face Labels for this filter. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
This does not work. The feature needs to be redesigned. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
topic/surface_nets_virtual_boundary_value
branch
from
10420df to
156ad24
Compare
…COMMIT IS JUNK The issue is that the outer virtual boundary Face Labels and the underlying FeatureIds do not agree. I think we may need to store the actual index offset into the FeatureIds array and then also store a reference to the FeatureIds array so that we can get the data consistently. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.