Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix format_pr workflow #1180

Merged
merged 3 commits into from
Jan 21, 2025
Merged

BUG: Fix format_pr workflow #1180

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1144a6e
Replaced fail_on_error with fail_level in reviewdog action
JDuffeyBQ Jan 17, 2025
043634a
Added intentional bad formatting for testing
JDuffeyBQ Jan 17, 2025
a205f39
Revert "Added intentional bad formatting for testing"
JDuffeyBQ Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/format_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ jobs:
uses: reviewdog/action-suggester@v1
with:
tool_name: clang-format
fail_on_error: true
fail_level: error
2 changes: 2 additions & 0 deletions src/simplnx/Plugin/AbstractPlugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@
std::string AbstractPlugin::getName() const
{
return m_Name;
}

Check failure on line 27 in src/simplnx/Plugin/AbstractPlugin.cpp

View workflow job for this annotation

GitHub Actions / clang_format_pr 

code should be clang-formatted [-Wclang-format-violations]



JDuffeyBQ marked this conversation as resolved.
Show resolved Hide resolved
std::string AbstractPlugin::getDescription() const
{
return m_Description;
Expand Down
Loading