ENH: Rename complex to simplnx #801
Conversation
imikejackson
requested review from
JDuffeyBQ,
nyoungbq,
joeykleingers,
mmarineBlueQuartz and
jmarquisbq
imikejackson
force-pushed
the
feature/simplnx_rename
branch
3 times, most recently
from
6a943b5 to
6c763a0
Compare
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
feature/simplnx_rename
branch
from
6c763a0 to
6c8b5d9
Compare
There was a problem hiding this comment.
Not an actual problem just a style warning:
Just a heads up on this file the all-contributors bot will post links with the uppercase BlueQuartzSoftware, since that is the way the URL is distributed. That being said I checked the github docs and organization names are case insensitive so it shouldn't matter either way (and URLS are obviously case insensitive when making requests outside the local OS filesystem). All this is to say that it isn't breaking and lowercase URLs conforms to typical conventions, but I fear uniformity may be broken when we add new contributors, since this is a niche styling decision that will likely not be considered/remembered when reviewing the new contributors PR.
There was a problem hiding this comment.
I'll get this cleaned up on the back side of this conversion.
The previous repo would have been at https://www.github.com/bluequartzsoftware/complex Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
The previous repo would have been at https://www.github.com/bluequartzsoftware/complex Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
The previous repo would have been at https://www.github.com/bluequartzsoftware/complex Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
The
complexlibrary is renamed to "SIMPLNX"