FILTER: Label Triangle Geometry and Remove Flagged Triangles Filters #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very quick glance at the code I think the Dynamic List array is going to have issues when Out-of-Core comes around. We cross that bridge when we get there. |
Yea the problem is that it's embedded throughout the geometry APIs, so if we want to remove it. It should really be a separate PR rather than be integrated into this one. |
nyoungbq
force-pushed
the
filter/label_triangle_geom
branch
from
2431de3 to
c98c094
Compare
imikejackson
force-pushed
the
filter/label_triangle_geom
branch
from
c98c094 to
9aa3b33
Compare
nyoungbq
force-pushed
the
filter/label_triangle_geom
branch
from
9aa3b33 to
2da3f07
Compare
…gacyUUIDMapping.hpp, and 6 more files
* Placeholder update on LabelTriangleGeometryTest using reverse_triangle_winding data instead to ensure that the filter can execute.
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
nyoungbq
force-pushed
the
filter/label_triangle_geom
branch
from
2da3f07 to
eef4306
Compare
imikejackson
approved these changes
Feb 2, 2024
10 tasks
|
Added an example pipeline, updated the STL_Models archive which broke the combine_stl_models test. Other branches/PRs are going to break during testing until this gets merged. |
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
filter/label_triangle_geom
branch
from
b772c4a to
21f084a
Compare
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…lueQuartzSoftware#842) Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net> Co-authored-by: Matthew Marine <matthew.marine@bluequartz.net> Co-authored-by: Michael Jackson <mike.jackson@bluequartz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
iif warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.mdfor a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.mdhas documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup