feat: Custom TypePath impl for component/resource #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to
TypePathrequirements for reflection,EntropyComponent/GlobalEntropymust have customTypePathimplementations in order to still be able to wrap aroundRngCorestructs without requiring upstream RNGs/randcrates to pull in bevy and implementTypePaththemselves. This PR allows for the shim to continue to exist without forcing this requirement to upstream RNGs, nor forcing the crate to not imposeTypePathtrait constraints onto the generics, forcing all users to need to newtype their RNGs just to provide theTypePathtrait.TODO
v0.11.1once bevy_reflect: Opt-out attribute forTypePathbevyengine/bevy#9140 is merged and the patch version is released.v0.11.1forv0.2.