Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

472 documentation issue latex vs math in all current code #473

Conversation

GerjanDorgelo
Copy link
Contributor

@GerjanDorgelo GerjanDorgelo commented Feb 2, 2025

Description

All LaTeX documentation has been added, where it used to be :math:

Fixes #472 and #460 and #458

Type of change

  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

Copy link

github-actions bot commented Feb 2, 2025

Thank you so much for contributing to Blueprints! This is your Pull Request # 19 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

@GerjanDorgelo GerjanDorgelo changed the title 472 documentation issue latex vs math in chapter 8-12 from nen en 1992 1 1 and all other ecs 472 documentation issue latex vs math in chapter 8-12 from nen en 1992 1 1 and all other Eurocodes Feb 3, 2025
@viktor-rick
Copy link
Collaborator

@GerjanDorgelo, could you create 1 PR with #461 and #459 to make review easier? If not, let me know so I can review this.

@GerjanDorgelo
Copy link
Contributor Author

@GerjanDorgelo, could you create 1 PR with #461 and #459 to make review easier? If not, let me know so I can review this.

i could make it into one massive PR, but opted for splitting it into three equalish parts. I dont mind both options, i just didnt wanna bombard one of you with 1500+ lines of code altered. Whatever you prefer

@viktor-rick
Copy link
Collaborator

I think it makes reviewing easier (look for no more :math: statements and build docs once to check it)

…er-5' into 472-documentation-issue-latex-vs-math-in-chapter-8-12-from-nen-en-1992-1-1-and-all-other-ecs
…4-and-6-and-7' into 472-documentation-issue-latex-vs-math-in-chapter-8-12-from-nen-en-1992-1-1-and-all-other-ecs
@GerjanDorgelo
Copy link
Contributor Author

I think it makes reviewing easier (look for no more :math: statements and build docs once to check it)

ah you planned to do it like that! Smart! Ill close the other two PRs and this one will be a big one then.

…ity and consistency in mathematical notation
@GerjanDorgelo GerjanDorgelo changed the title 472 documentation issue latex vs math in chapter 8-12 from nen en 1992 1 1 and all other Eurocodes 472 documentation issue latex vs math in all current code Feb 3, 2025
@viktor-rick
Copy link
Collaborator

viktor-rick commented Feb 3, 2025

Fine for now, probably needs reviewing after mkdocs implementation. I checked:

All modules for following regex

  • :math:
  • if not re.search(r'\$\$.*?\$\$', docstring) and re.search(r'\[.*?\]', docstring):

@GerjanDorgelo
Copy link
Contributor Author

Fine for now, probably needs reviewing after mkdocs implementation. I checked:

All modules for following regex

* [x]  :math:

* [x]  `if not re.search(r'\$\$.*?\$\$', docstring) and re.search(r'\[.*?\]', docstring):`

Awesome! Can you press the big approve and merge buttons then?

…pter-8-12-from-nen-en-1992-1-1-and-all-other-ecs
Copy link
Collaborator

@viktor-rick viktor-rick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check

…pter-8-12-from-nen-en-1992-1-1-and-all-other-ecs
@viktor-rick viktor-rick merged commit 206f123 into main Feb 10, 2025
3 checks passed
@viktor-rick viktor-rick deleted the 472-documentation-issue-latex-vs-math-in-chapter-8-12-from-nen-en-1992-1-1-and-all-other-ecs branch February 10, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📚 Documentation Issue]: latex vs :math: in chapter 8-12 from nen-en-1992-1-1 and all other ECs
2 participants