-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
472 documentation issue latex vs math in all current code #473
472 documentation issue latex vs math in all current code #473
Conversation
…luation and add LaTeX representation
…3 chapter 3 4 6 and 7
… clarity and consistency
…rity and consistency
…rity and consistency
…essions and update parameter types to DIMENSIONLESS where applicable
…sions in various files
…essions and update parameter types to DIMENSIONLESS where applicable
Thank you so much for contributing to Blueprints! This is your Pull Request # 19 to this project. Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
…se LaTeX-style units
…TIO type instead of DIMENSIONLESS
… of DIMENSIONLESS
…ate docstring formatting for clarity
@GerjanDorgelo, could you create 1 PR with #461 and #459 to make review easier? If not, let me know so I can review this. |
blueprints/codes/eurocode/nen_9997_1_c2_2017/chapter_1_general_rules/formula_1_0_1.py
Show resolved
Hide resolved
i could make it into one massive PR, but opted for splitting it into three equalish parts. I dont mind both options, i just didnt wanna bombard one of you with 1500+ lines of code altered. Whatever you prefer |
I think it makes reviewing easier (look for no more :math: statements and build docs once to check it) |
…er-5' into 472-documentation-issue-latex-vs-math-in-chapter-8-12-from-nen-en-1992-1-1-and-all-other-ecs
…4-and-6-and-7' into 472-documentation-issue-latex-vs-math-in-chapter-8-12-from-nen-en-1992-1-1-and-all-other-ecs
ah you planned to do it like that! Smart! Ill close the other two PRs and this one will be a big one then. |
…ity and consistency in mathematical notation
Fine for now, probably needs reviewing after mkdocs implementation. I checked: All modules for following regex
|
Awesome! Can you press the big approve and merge buttons then? |
…pter-8-12-from-nen-en-1992-1-1-and-all-other-ecs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check
…pter-8-12-from-nen-en-1992-1-1-and-all-other-ecs
Description
All LaTeX documentation has been added, where it used to be :math:
Fixes #472 and #460 and #458
Type of change
Checklist: