Security fix. Upgrade to gulp 4.0.0 #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security issue is with gulp 3.9.1 and the fix is to upgrade to gulp 4.0.0
Following the official documentation and this post, I've upgraded this to gulp 4.0.0.
It's important to point out that things like:
gulp.task('default', ['a', 'b'], function() { /*code*/ });
become
gulp.task('default', gulp.series('a', 'b', function() { /*code*/ }));
and also, tasks must be defined before being called. You must define tasks like
sass
,sass:lint
,... before calling it. Otherwise you will get this error:AssertionError [ERR_ASSERTION]: Task never defined: sass:lint
I didn't see anything in the README.md to indicate how to upgrade, from 3.9.1 to 4.0.0 so I didn't added anything there.