Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for other fluids and air #21

Merged
merged 21 commits into from
Jul 27, 2024

Conversation

cayossarian
Copy link
Contributor

@cayossarian cayossarian commented Jul 27, 2024

closes #13

   AIR
   FRESH_WATER
   WASTE_WATER
   LIVE_WELL
   BLACK_WATER
   RAW_WATER 
   GASOLINE
   DIESEL
   LNG
   OIL
   HYDRAULIC_OIL

Tested with TDR40 top down sensor for air (water tank) and tests added accordingly. Corresponding issue will be opened in HA core with the associated pull request there.

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base (80615f6) to head (0cc7063).
Report is 3 commits behind head on main.

Files Patch % Lines
src/mopeka_iot_ble/parser.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   87.83%   90.90%   +3.07%     
==========================================
  Files           2        3       +1     
  Lines          74       99      +25     
  Branches        5        7       +2     
==========================================
+ Hits           65       90      +25     
  Misses          6        6              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco force-pushed the feature/mopeka-medium-types branch from 66a0a3d to 3f06932 Compare July 27, 2024 12:29
@bdraco bdraco changed the title Addresses Issue #13 by adding support for other fluids and air feat: add support for other fluids and air Jul 27, 2024
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cayossarian

@bdraco bdraco merged commit 5c67178 into Bluetooth-Devices:main Jul 27, 2024
7 of 8 checks passed
@bdraco
Copy link
Member

bdraco commented Jul 27, 2024

0.8.0 published

@bdraco
Copy link
Member

bdraco commented Jul 27, 2024

Also in HA, please implement as a config entry options flow

@cayossarian cayossarian deleted the feature/mopeka-medium-types branch July 27, 2024 13:58
@chadroad
Copy link

chadroad commented Sep 1, 2024

With these new Mopeka updates is there a way to have HA display the reading in percentage instead of inches please?

The Mopkea app allows you to change them, but not in HA. If not can you please provide some sample code that would make this work?

I am using the Pro-H20 sensors on RV water tanks but they are different sizes. One is 8" in height and the other is 6". Those inch readings have to be specified inside the Mopeka app for each tank. Both are 30 gal tanks, but their physical size dimensions are different. Any help you could give would be greatly appreciated.

@cayossarian
Copy link
Contributor Author

Hi @chadroad Let's take this discussion to the community board so you can hear from others as well. I'll post a reply there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for other fluids
3 participants