-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for other fluids and air #21
feat: add support for other fluids and air #21
Conversation
…o feature/mopeka-medium-types
…o feature/mopeka-medium-types
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 87.83% 90.90% +3.07%
==========================================
Files 2 3 +1
Lines 74 99 +25
Branches 5 7 +2
==========================================
+ Hits 65 90 +25
Misses 6 6
Partials 3 3 ☔ View full report in Codecov by Sentry. |
66a0a3d
to
3f06932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cayossarian
0.8.0 published |
Also in HA, please implement as a config entry options flow |
With these new Mopeka updates is there a way to have HA display the reading in percentage instead of inches please? The Mopkea app allows you to change them, but not in HA. If not can you please provide some sample code that would make this work? I am using the Pro-H20 sensors on RV water tanks but they are different sizes. One is 8" in height and the other is 6". Those inch readings have to be specified inside the Mopeka app for each tank. Both are 30 gal tanks, but their physical size dimensions are different. Any help you could give would be greatly appreciated. |
Hi @chadroad Let's take this discussion to the community board so you can hear from others as well. I'll post a reply there. |
closes #13
Tested with TDR40 top down sensor for air (water tank) and tests added accordingly. Corresponding issue will be opened in HA core with the associated pull request there.