Add specific gravity device class and units #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 93.44% 93.47% +0.03%
==========================================
Files 12 12
Lines 412 414 +2
Branches 25 25
==========================================
+ Hits 385 387 +2
Misses 26 26
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bdraco
reviewed
Aug 30, 2022
|
If you rebase and prefix the commit message with feat: And make the first character lowercase the CI should pass |
apt-itude
force-pushed
the
specific-gravity
branch
from
35654ec to
8132a2f
Compare
bdraco
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for the Tilt BLE sensor here. Still have an open question about the units since this sensor is truly unitless. I made it just "SG" for now in case we need to just fill in something.