-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial implementation #1
feat: initial implementation #1
Conversation
key=DEVICE_CLASS_SG, | ||
device_class=DEVICE_CLASS_SG, | ||
native_unit_of_measurement=UNITS_SG, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure what to do about device class and units for this sensor. The device class is relatively unusual (specific gravity) and it's really unit-less, but from what I can tell omitting units doesn't work so well in HA.
Do I need to define this in the sensor-state-data
library first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it needs something in sensor state data first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can it actually be unit-less, or do I just need to make something up? Like G
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you bring it into Home Assistant, map the units to None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the device class should also send None to HA, isn’t it? Specific gravity is not a HA device class.
9f4892c
to
65319fa
Compare
@apt-itude What is your PyPI handle? |
@apt-itude I'm on holiday starting tomorrow so I didn't want to leave you hanging. I got the auto publication workflow and tokens working so as long as the CI passes it should publish new changes based on the commit message format. (https://www.conventionalcommits.org/en/v1.0.0-beta.2/#summary) @Ernst79 can add you to the PyPI package. |
In case you still need it, same as here: |
Initial implementation of parser for Tilt Hydrometer devices to be used by Home Assistant integration.
This has been running successfully as part of a custom component on my Home Assistant for a few weeks now.
@Ernst79 Apologies: I let the invite to contribute directly to the upstream repo expire