Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: pass process error code to BuildError #556

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

KevinSlijepcevic
Copy link

This change shall enable Bob to return a process error code in an invoked process to the caller of a Bob command, e.g. bob dev test.

Afterwards, it shall be possible to evaluate the returned error code with echo $?, which currently always returns 1.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (9630b0f) to head (27d791f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #556   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files          46       46           
  Lines       14803    14803           
=======================================
  Hits        13165    13165           
  Misses       1638     1638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkloetzke jkloetzke merged commit 5363c6c into BobBuildTool:master Mar 5, 2024
11 checks passed
@jkloetzke
Copy link
Member

Thanks!

@KevinSlijepcevic KevinSlijepcevic deleted the return-error-code branch March 5, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants