input: add 'inherit' dependency property #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkloetzke
reviewed
May 23, 2024
rhubert
force-pushed
the
clean_dep
branch
3 times, most recently
from
f383aaf to
ff60e4e
Compare
rhubert
changed the title
This property controls the inheritance of environment, tools and sandbox for a dependency. It defaults to true so everything is inherited. If set to `false` environment, tools and sandbox are dropped. The dependency starts with the default-environment, no tools and no sandbox. This becomes particularly useful when an existing root-package should become a dependency of another root-package, e.g. for building an installer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #565 +/- ##
==========================================
- Coverage 79.72% 79.71% -0.01%
==========================================
Files 46 46
Lines 14693 14723 +30
==========================================
+ Hits 11714 11737 +23
- Misses 2979 2986 +7 ☔ View full report in Codecov by Sentry. |
|
Thanks for fixing this! I did some testing this morning and it works like expected. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property controls the inheritance of environment, tools and sandbox
for a dependency. It defaults to true so everything is inherited.
If set to
falseenvironment, tools and sandbox are dropped. Thedependency starts with the default-environment, no tools and no sandbox.
This becomes particularly useful when an existing root-package should
become a dependency of another root-package, e.g. for building an
installer.