Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disabled dependencies variable substitutions #575

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Fix disabled dependencies variable substitutions #575

merged 3 commits into from
Jul 9, 2024

Commits on Jul 7, 2024

  1. test: add unit test that disabled deps can be provided

    @jkloetzke
    jkloetzke committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    772c9eb View commit details
    Browse the repository at this point in the history

  2. input: evaluate deps condition first 

    If a dependency is disabled, all other variable substitutions in this
dependency shall be skipped. That has been the case already, except the
dependency name itself. Unfortunately, just moving the condition check
to the front is not sufficient because it is allowed to name disabled
dependencies in provideDeps. So we do the name substitution anyway but
will ignore a failure if the dependency shall be skipped.
    @jkloetzke
    jkloetzke committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    8ccdb4f View commit details
    Browse the repository at this point in the history

  3. test: add unit test for deps substitution order

    @jkloetzke
    jkloetzke committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    783d141 View commit details
    Browse the repository at this point in the history