Conditional tools #576
Merged
Conditional tools #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhubert
reviewed
Jul 15, 2024
To calculate the variant-id, the applicable tools for each step must be known. The variant-id of a step is calculated already in its constructor. So far this worked because the list of used tools was static for each recipe. Now that we want to make tool usage conditional, we have to pass the tool mask directly into each step.
Sometimes a recipe might only require a tool if certain conditions are
met. So far, tools could only be used unconditionally. This adds a new
syntax along the following lines:
checkoutTools:
- if: "${TEST_VAR:-}"
name: graphics::package
Fixes BobBuildTool#572.
jkloetzke
force-pushed
the
conditional-tools
branch
from
bf40d30 to
52f4452
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
==========================================
- Coverage 88.67% 88.66% -0.01%
==========================================
Files 46 46
Lines 14857 14837 -20
==========================================
- Hits 13174 13155 -19
+ Misses 1683 1682 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for conditional tool usage...