layers: fix move to attic #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the layers where updated from bob build/dev move to attic was disabled by default. As the unittest only tests the attic move from `bob layers update` this has been overlooked as attic is True in this case while it's None for build/dev. Adapt the default for the layers update command to match the default from build/dev.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #593 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 48 48
Lines 15339 15339
=======================================
Hits 13636 13636
Misses 1703 1703 ☔ View full report in Codecov by Sentry. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the layers where updated from bob build/dev move to attic was disabled by default.
As the unittest only tests the attic move from
bob layers updatethis has been overlooked as attic is True in this case while it's None for build/dev. Adapt the default for the layers update command to match the default from build/dev.