Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mediaplayer remake && refactor: added ktfmt #15

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

BobbyESP
Copy link
Owner

This pull request introduces several enhancements and new features to the app/mediaplayer module, including dependency updates, new services, and repository implementations. The changes are primarily focused on improving the media player functionality and adding new capabilities for media scanning and playback services.

Dependency and Plugin Updates:

  • Added ktfmt plugin to app/build.gradle.kts and app/mediaplayer/build.gradle.kts for Kotlin code formatting. [1] [2]
  • Added core-utilities module as a dependency in app/build.gradle.kts and app/mediaplayer/build.gradle.kts. [1] [2]

Media Player Enhancements:

  • Updated AndroidManifest.xml to include the new PlaybackService and the required permissions for media playback.
  • Implemented PlaybackService to handle media playback using ExoPlayer and MediaLibraryService.
  • Refactored MediaPlayerModule.kt to use the new PlaybackService and simplified dependency injection.

Repository Implementations:

  • Added MediaStoreFolderScannerImpl for scanning custom folders and forcing MediaStore to scan specified folders.
  • Added MusicScannerImpl for querying and observing the music library using MediaStore.

New Enums:

  • Added AudioChannels enum to represent different audio channel configurations.
  • Added MediaStoreSearchFilter enum to facilitate filtering in MediaStore queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant