Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current version of openmidi dependency has Undefined Behaviour on MacOS #138

Closed
marcushaddon opened this issue Oct 26, 2023 · 5 comments
Closed

Comments

@marcushaddon
Copy link

When using midir on MacOS with coremidi, i inevitably get panics related to misaligned pointer dereference: address must be a multiple of 0x4 but is 0x7000115af679, which originate inside of coremidi. Looking at their issues, it seems that this was a known issue that has been fixed (chris-zen/coremidi#24). The fix is available in 0.7.0 but midir still depends on 0.6.0, and will not accept a [patch]'ed version.

Would it be possible to upgrade to coremidi = 0.7.0?

Boddlnagg added a commit that referenced this issue Oct 27, 2023
Boddlnagg added a commit that referenced this issue Oct 27, 2023
@Boddlnagg
Copy link
Owner

Can you test if #139 fixes it? I don't have a macOS machine right now to test it, but according to CI looks good.
I'm a little confused because the linked issue doesn't mention anything about misaligned addresses (only MaybeUninit and null pointers), so I'm curious to see if it actually helps with your issue.

@Boddlnagg
Copy link
Owner

I just released midir 0.10.0 which now depends on coremidi 0.8.0

@Boddlnagg
Copy link
Owner

I actually don't think that this was fixed by coremidi 0.7, but probably chris-zen/coremidi#49 instead

@Boddlnagg Boddlnagg reopened this May 9, 2024
@Boddlnagg
Copy link
Owner

This should be fixed with the latest version of coremidi-sys. I will publish a version with updated dependency soon.

@Boddlnagg
Copy link
Owner

Actually a new version is not needed (and coremidi-sys is not even a direct dependency of midir). cargo update should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants