Fix clippy warnings #136
Open
Fix clippy warnings #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barafael
force-pushed
the
fix_clippy_warnings
branch
4 times, most recently
from
cb9a7d2 to
ef66de1
Compare
barafael
force-pushed
the
fix_clippy_warnings
branch
2 times, most recently
from
e7fa1c7 to
261df16
Compare
And fix compilation errors, mostly imports
barafael
force-pushed
the
fix_clippy_warnings
branch
from
261df16 to
135215e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building upon the changes #134 and #135, a bunch of new clippy lints surfaced.
I fixed all the default clippy lints and chose a good selection (according to me) of the lints in
clippy::pedanticandclippy::nursery.Many changes are very simple, such as using struct initializer shorthand or let-else instead of let-if-let.
Let me know what you think.