Add comprehensive trait implementations and testing #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenaudDenis
force-pushed
the
feature/common-traits
branch
2 times, most recently
from
81768fa to
b1783fd
Compare
Add essential trait implementations (Debug, Hash, PartialEq, Eq) to core MIDI types for better production usage and testability. The changes improve: - Port usage as hash map keys - Testing capabilities - Error messages via Debug implementations Breaking changes: None
RenaudDenis
force-pushed
the
feature/common-traits
branch
from
da78c4e to
c0a253b
Compare
|
Hi @Boddlnagg, nice to meet you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add essential trait implementations (Debug, Hash, PartialEq, Eq) to core MIDI types for better production usage and testability.
The changes improve:
Breaking changes: None