WIP: Remove 'static constraint on callbacks #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boddlnagg
reviewed
Jun 19, 2020
src/common.rs
Outdated
| @@ -53,7 +53,7 @@ pub struct MidiInput { | |||
| imp: MidiInputImpl | |||
| } | |||
|
|
|||
| impl MidiInput { | |||
| impl<'a> MidiInput { | |||
There was a problem hiding this comment.
Why is the lifetime added to the impl instead of the function connect where it's needed?
There was a problem hiding this comment.
That was the first thing that came to my mind in order to fix the lifetime compile errors. For some reason I didn't think of making the lifetime connect-specific. Fixed in 8727d91
kangalio
changed the title
|
Closing because this unfortunately cannot work (as explained in #44 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #44, this removes the 'static constraint on message callbacks by leveraging the
thread-scopedcrate.So far I made the ALSA, JACK and WinMM backend work.