Fix for #135 -- when using the PickleEncoder #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k view still works by showing a representation of the kwargs which is json serializable
andrewgy8
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Thanks @huubbouma for the change! And sorry it took a while 😄
|
Fixes #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the PickleEncoder make sure the task view still works by showing a representation of the kwargs which is json serializable
This fixes an issue for me when I wasn't able to see the task details
Each kwarg is simply replaced by a string representation if an encoder other than the JSONEncoder is used