feature: add middleware after_{consumer,worker}_thread_boot hooks #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the middleware to run code in the context of a worker or consumer thread before it enters its run loop. This could be used to set up thread-local resources, or as in the author's case, to get a reference to the thread before it does any work. This was proposed on the mailing list [0] with Bogdan accepting the idea in principle [1]. [0]: https://groups.io/g/dramatiq-users/topic/105311701 [1]: https://groups.io/g/dramatiq-users/topic/105311701#258
|
converted to draft; will mark it ready for review after we've run our code using the hooks for a few days to be sure these hooks are adequate |
|
@Bogdanp we've been runing a cherry-pick of this onto the version we use in prod and it's allowed us to start workers in a paused state as described in the mailing list. |
|
Thanks! |
|
@Bogdanp quick question: do you expect to make a release containing this any time soon? like I said we're running with a cherry-pick which is fine, mostly just want to have a mental note to do the upgrade if / when it's released. thanks! |
|
@kamalmarhubi I plan to make a release sometime next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the middleware to run code in the context of a worker or consumer thread before it enters its run loop. This could be used to set up thread-local resources, or as in the author's case, to get a reference to the thread before it does any work.
This was proposed on the mailing list 0 with Bogdan accepting the idea in principle 1.