Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add support for static files #176

Merged
merged 5 commits into from
May 11, 2021
Merged

Conversation

tchock
Copy link
Member

@tchock tchock commented May 10, 2021

No description provided.

Copy link
Contributor

@JohannesMerz JohannesMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny request

});
});

test('When staticDir is a string, make it an array of one string', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a test for mult. comma separated options

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't done here though

@tchock tchock merged commit 0919220 into master May 11, 2021
@tchock tchock deleted the static-folder-support branch May 11, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants