Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy: custom out of stock validation error fix #1912

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

garmashdev
Copy link
Collaborator

@garmashdev garmashdev commented Dec 18, 2024

Description

Legacy mode: updated error response to the correct "out of stock" type for any custom exception which contain out of stock in its message

Fixes: update error response to correct "out of stock" type for any custom exception which contain out of stock in its message

#changelog Legacy: custom out of stock validation error fix

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please validate that you have tested your change in at least one of the following areas:

  • Successfully tested locally (or docker image)
  • Successfully tested on a staging or sandbox server
  • Successfully tested on a merchant's staging server

For PR Reviewer

  • Reviewed unit tests to make sure we are using real components rather than mocks as much as possible?
  • For any major change (observer, new Bolt feature, core Magento interaction) we must add a feature switch, did you verify this?

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • New and existing unit tests pass locally with my changes.
  • I have created or modified unit tests to sufficiently cover my changes.
  • I have added my ticket link and provided a changelog message.

@garmashdev garmashdev requested a review from a team as a code owner December 18, 2024 07:50
@garmashdev garmashdev requested review from pejter and dumega December 18, 2024 07:51
@garmashdev garmashdev merged commit 2349cf0 into master Dec 19, 2024
10 checks passed
@garmashdev garmashdev deleted the ygarmash/custom_out_of_stock_err branch December 19, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants