Add libxml2 app link resolver

[conradev]

I added a BFXMLAppLinkResolver to resolve links using libxml2.

This is because loading the URL in a UIWebView is often unnecessary.

[josephearl]

Needs rebase

[josephearl]

Looks good, but why is the old resolver removed? This will break all old clients.

It would be better to have both resolvers and refactor any shared code into a ResolverHelper or similar class.

This also adds a dependency to the library - @nlutsenko-fb does that matter?

[conradev]

I went ahead and made the requested changes – the resolvers now co-exist and share code. I also updated the tests to test both resolvers 👍

Hopefully libxml2 isn't a big deal because it's built into the system (and has been there since iOS 2.0).

[conradev]

Any progress on this?

[conradev]

Rebased against master

[nlutsenko]

@conradev The tests are failing here.
Any chance you can fix them?

[conradev]

@nlutsenko, I rebased against master again, and pushed.

[conradev]

The error only appears to be showing in xctool. This is because xctool doesn't handle parameterized tests, which I use to test each resolver individually.

[nlutsenko]

Since merging this in will break tests for all PRs - let me try to change our travis config to use xcpretty instead. PR is coming... ;D

[conradev]

🐫

If I rebase against master, is there a chance that it would be merged?

[conradev]

I rebased this against master!

[facebook-github-bot]

@conradev updated the pull request.

[conradev]

Rebased again! 👍

[nlutsenko]

Whee! Ok, then we'll review it very very soon.
Also, cc @richardjrossiii for libxml2.

[conradev]

Rebased again! 😛

[conradev]

I went and rebased the PR against master. Would love to see this get merged! ⛵

[RedDragonLS]

I am new to this friend, please let me know if I shouldn't be doing this: ) Sorry for disruptions

Sent from Yahoo Mail on Android

On Thu, 30 Jun, 2016 at 23:45, Conrad Kramernotifications@github.com wrote:
I went and rebased the PR against master. Would love to see this get merged! ⛵

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[nlutsenko]

Am going to review this and get back to you.

[RedDragonLS]

Thank you for your time :)

Sent from Yahoo Mail on Android

On Fri, 1 Jul, 2016 at 2:00, Nikita Lutsenkonotifications@github.com wrote:
Am going to review this and get back to you.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.