fix: bail validation and refactor create button labels #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dni
commented
Mar 11, 2024
dni
commented
- button label is now way easier to work with
- validation only happens if there is a amount set at all
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
closes #443 |
|
closes #353 |
This was
linked to
issues
Mar 15, 2024
michael1011
approved these changes
Mar 15, 2024
kilrau
requested changes
Mar 15, 2024
There was a problem hiding this comment.
#443 seems to be fixed, couldn't get web app to resolve my lightning address with invalid/empty amounts
#353 for empty amounts the "Please provide a valid LN invoice, LNAddress or LNURL" should be shown too if I enter sth invalid:
Same for Normal Swaps with empty amounts, it should show "Invalid BTC address"
kilrau
requested changes
Mar 19, 2024
dni
force-pushed
the
bail-validation
branch
2 times, most recently
from
7fccda7 to
f976865
Compare
- button label is now way easier to work with - validation only happens if there is a amount set at all invalid invoice label add invalid address label check fixup issue with webln on 0 amount remove sat amount from placeholder prettier
michael1011
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.