Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP extra options #146

Closed
sebastianlau opened this issue Jul 9, 2016 · 3 comments
Closed

SMTP extra options #146

sebastianlau opened this issue Jul 9, 2016 · 3 comments

Comments

@sebastianlau
Copy link

Currently swiftmailer tries to HELO as [::1] causing a rejection, it'd be good if server_name could be specified in .env which consequently runs $transport->setLocalDomain($server_name);

Additionally, settings for sender address and an email_base_url would be very useful to set in .env as emails are sent as BookStack mail@bookstackapp.com, and if a reverse proxy is in place the email url contains incorrect/internal links (e.g. http://localhost:8080/password/reset/......)

@armouredking
Copy link

Part of that is #88 and a function of Laravel. Laravel does not inherently trust proxies. You need to add in an extra layer that BSA doesn't currently include if you want BSA behind a proxy. Then your email links will be correct.

@ssddanbrown
Copy link
Member

Hi @sebastianlau, In the .env file you can customize the sender address by adding a MAIL_FROM entry, For example:

MAIL_FROM=bookstack@mydomain.com

I'll look into your other issues at somepoint soon.

@ssddanbrown
Copy link
Member

Now closing this due to the current master branch code having configurable proxy settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants