Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: when uploading more than one image, once upload finishes, UI shows multiple instances of one image #3160

Closed
vrozkovec opened this issue Jan 12, 2022 · 1 comment

Comments

@vrozkovec
Copy link

vrozkovec commented Jan 12, 2022

Describe the Bug

When uploading more than one image, once upload finishes, UI shows multiple instances of one image.

Steps to Reproduce

Fresh install, trying to upload several images at once, clicking grey button at the top right corner
image

Selecting two images, hitting upload
image

State after upload finishes:
image

Expected Behaviour

Each uploaded image shows only once after uploading.

Screenshots or Additional Context

No response

Exact BookStack Version

BookStack v21.12.2

PHP Version

7.4

Hosting Environment

Ubuntu 20.04 VM
Nginx

@vrozkovec vrozkovec changed the title [Bug Report]: when uploading more than one image, once upload finishes, ui shows multiple instances of one image [Bug Report]: when uploading more than one image, once upload finishes, UI shows multiple instances of one image Jan 13, 2022
@ssddanbrown ssddanbrown added this to the v21.12.3 milestone Jan 24, 2022
@ssddanbrown ssddanbrown self-assigned this Jan 24, 2022
ssddanbrown added a commit that referenced this issue Jan 24, 2022
Quick patch to clear the gallery display when getting the first page.
Duplication of the galler was occuring due to the mulitple upload events
loading the gallery mulitple times while only clearing the existing
gallery at the start of all refreshes.

A bit flashy in terms of user experience, as there will still be
mulitple load/clear events but fixes the duplication. Could be done more
elegently in future by communicating up image upload counts.

For #3160
@ssddanbrown
Copy link
Member

Thanks for reporting @vrozkovec. Can confirm this issue and have patched within 4aed3f8 which will be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants