PDF Export issue #392

Dav31 · 2017-05-11T12:56:28Z

BookStack Version: 0.16.2
PHP Version: 5.6.30
MySQL Version: 5.5.52-MariaDB

Hi,
Firstly, thank's a lot for this tool.
Secondly, I have an issue with PDF exports.
When I try to export an article as PDF, all images are missing from the file created.

I tried to use WKHTMLTOPDF instead, but without success.

ssddanbrown · 2017-05-28T10:31:05Z

Hi @Dav31, Sorry for my late reply. Were the images uploaded via BookStack or are the referencing another website? What OS is your BookStack instance running on? How large are the images?

Dav31 · 2017-05-29T12:27:26Z

Hi Dan,

No problem for the late.
Yes, the images are on the server where Bookstack is hosted.
My instance is running on a CentOS server vith Ngnix webserver installed.
For the images, this is variable as no images are displayed on the PDF export, whatever how large they are.

the4ndy · 2017-05-31T18:12:56Z

I am also experiencing this issue....i have been since starting using Book Stack almost 1 year ago....i, until recently, thought this was just the natural behavior of the PDF export feature (and was actually coming here to request that feature be added).

I am running the latest version of book stack (just updated today) 0.16.2. I am running it on Ubuntu 16.04 (up to date) with an Nginx webserver
php --version = 7.0.18
mysql --version = 14.14 distrib 5.7.18

vladime · 2017-08-04T10:16:32Z

Same issue here... Running as a docker container.
Ubuntu 16.04
Docker 17.06.0-ce
Nginx
mysql 5.7.12

Alwaysin · 2017-08-04T10:27:55Z

Same here!

Debian 9
PHP 7.0.19-1
10.1.23-MariaDB-9+deb9u1
apache2 2.4.25-3+deb9u2

pabloalbrecht · 2017-08-05T12:42:13Z

Same here... also if you export to HTML
Debian 14, Debian 16
PHP 7 / Nginx

ssddanbrown · 2017-08-06T12:29:05Z

Hi @vladime, Are you using the popular solidnerd/docker-bookstack setup for docker or a different setup? A docker setup with this issue would be ideal for me to try to replicate the issue.

vladime · 2017-08-06T15:17:24Z

Hi Dan, yes, I am using solidnerd docker with BS 0.17.1. One detail which is might be important: I am using Ngnix, so the whole path looks like this domain.com/wiki/restofthebookstackpath/

…

On 6. Aug 2017, at 14:29, Dan Brown ***@***.***> wrote: Hi @vladime, Are you using the popular solidnerd/docker-bookstack setup for docker or a different setup? A docker setup with this issue would be ideal for me to try to replicate the issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

julienmmm · 2017-08-21T05:40:11Z

Hello,

I am also facing the same issue with the pdf exporter (Install on Fedora 25).

Also note that I have the same issue with the "Web contained file" exporter.

Dav31 · 2017-09-07T14:59:40Z

Hello,

I just updated to 0.17.4 version.
The issue still occurs.
It seems to be directly linked to NGinx.

Regards.

jacksonp2008 · 2017-09-08T13:53:50Z

Yes, must be NGINX related. I see this on behavior on a system that is using NGINX, but it works fine on the latest docker container without NGINX.

nblenkhorn · 2017-09-11T13:15:57Z

I am also seeing this behaviour on Apache. I'm using v0.17.4 as well.

megamorf · 2017-09-12T02:45:50Z

I'm also seeing this issue, running https://github.com/solidnerd/docker-bookstack behind Traefik as SSL terminating reverse proxy.

ssddanbrown · 2017-09-23T08:56:08Z

Hey everyone, Can someone (That has this issue) please confirm if the 'Contained HTML File' export works for them with images?

Need to know if the issue is in the document creation or PDF rendering code...

julienmmm · 2017-09-23T13:34:16Z

Hello, I am facing the same issue with the self contained html export. Julien Le 23 sept. 2017 10:56, "Dan Brown" <notifications@github.com> a écrit :

…

Hey everyone, Can someone (That has this issue) please confirm if the 'Contained HTML File' export works for them with images? Need to know if the issue is in the document creation or PDF rendering code... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#392 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXg9t7S7ZoXDttVjkLBfUpUhwXcTAq7-ks5slMeqgaJpZM4NX9PJ> .

megamorf · 2017-09-24T14:53:34Z

Can confirm, images are also missing with the html export.

Dav31 · 2017-09-25T07:36:46Z

Hi Dan,

I can confirm this too.
The HTML export doesn't provide us the images.

David

Added domain check to see if possibly local even when whole url found. Changed image fetch from file_get_contents to curl for external resources. Hopeful solution to #392

ssddanbrown · 2017-10-06T20:11:48Z

Hi all, I've just deployed version v0.18.3 to specifically target this issue. I have an idea at what the problem could be but I'm not sure until it's tested by a few different people but hopefully this patch will get things working.

I did test this in a local dev container setup where images did not work before but there may be a different issue at play here.

Please let me know how it goes after updating.

megamorf · 2017-10-07T02:06:23Z

@ssddanbrown Nice, I'm going to test this tomorrow and let you know 👍

megamorf · 2017-10-07T20:10:44Z

@ssddanbrown Getting a Whoops, looks like something went wrong. error when replacing ExportService.php with your version. The error log only shows a 500 error for the GET /books/playground/page/new-page/export/pdf request.

I hope some other folks can chime in as the addition of docker with a reverse proxy certainly increases complexity.

Alwaysin · 2017-10-08T14:24:53Z

It works for me, but I think a previous release already fixed it.

julienmmm · 2017-10-09T06:14:25Z

Hello,

After the upgrade to the latest version, all the images in all the documents appear as Broken link images:

But after editing the page and re-uploaded the images, they were correctly displayed and exported in the PDF.

Regarding the upload of images, I've been forced to upload them via the "insert image" button while I was used to do a copy/paste from a screenshot tool before. Now the copy paste does not work and BookStack displays a general error message when trying to upload images this way.

But I suppose it can be the subject of another issue.

Dav31 · 2017-10-13T08:30:33Z

Hi Dan,

I just updated my BookStack installation, and the PDF export runs just fine now.
Thank you very much for your support.

David

aljawaid · 2017-11-26T12:03:06Z

Hello I had the same problem on 0.18.0. I updated to 0.18.5 and the export to pdf now works but as per below:

you must use uploaded images only
ctrl+c results in an unknown error, so it doesn't work anymore.
existing images wont work

aljawaid · 2017-11-29T11:43:53Z

Hello,

The only problem now is that the image does not stay (on pdf) in the position it is meant to.

adrie-tc · 2018-01-18T14:11:51Z

I am faced with image issues as well, using the export to PDF function.
It produces results as shown by @julienmmm having broken images.
These are with freshly uloaded images however.
Using docker and a reverse proxy (nginx).
The issue (or rather solution) is still unresolved i take it?

adrie-tc · 2018-02-20T12:50:47Z

FYI, beta release v0.20.0 seems to have fixed it.
Testing a random sample of PDF exports containing media does not show any issues regarding images anymore.

ssddanbrown · 2018-03-05T20:10:22Z

Happy to hear this has been resolved for a good number of instances. Still looks like we're getting bugs though so I'll keep his open for continued discussions.

adrie-tc · 2018-03-06T08:08:05Z

I noticed the images coming from the new draw.io integration do not show up in the pdfs.
Instead they get replaced by a crossed out block image.

Normal view and HTML export are fine ofcourse.

ghost · 2018-04-05T17:52:02Z

Hi, will this work if images are secure, i mean by using the "local_secure_setting"?

alexmannuk · 2020-08-24T20:01:21Z

Appears to be fixed in all recent versions on both Apache and Nginx, no updates to the issue since 2018 so can likely be closed.

ssddanbrown · 2021-05-04T20:01:50Z

Thanks @alexmannuk.

I'll close this off since the original issue creator expressed that their issue has been since solved.

ssddanbrown added the 🐛 Bug label Aug 6, 2017

ssddanbrown added a commit that referenced this issue Oct 6, 2017

Updated image fetching in exporting

9758872

Added domain check to see if possibly local even when whole url found. Changed image fetch from file_get_contents to curl for external resources. Hopeful solution to #392

ssddanbrown closed this as completed May 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PDF Export issue #392

PDF Export issue #392

Dav31 commented May 11, 2017

ssddanbrown commented May 28, 2017

Dav31 commented May 29, 2017

the4ndy commented May 31, 2017

vladime commented Aug 4, 2017

Alwaysin commented Aug 4, 2017

pabloalbrecht commented Aug 5, 2017

ssddanbrown commented Aug 6, 2017

vladime commented Aug 6, 2017 via email

julienmmm commented Aug 21, 2017

Dav31 commented Sep 7, 2017

jacksonp2008 commented Sep 8, 2017

nblenkhorn commented Sep 11, 2017

megamorf commented Sep 12, 2017

ssddanbrown commented Sep 23, 2017

julienmmm commented Sep 23, 2017 via email

megamorf commented Sep 24, 2017

Dav31 commented Sep 25, 2017

ssddanbrown commented Oct 6, 2017

megamorf commented Oct 7, 2017

megamorf commented Oct 7, 2017 •

edited

Loading

Alwaysin commented Oct 8, 2017

julienmmm commented Oct 9, 2017

Dav31 commented Oct 13, 2017

aljawaid commented Nov 26, 2017

aljawaid commented Nov 29, 2017

adrie-tc commented Jan 18, 2018

adrie-tc commented Feb 20, 2018

ssddanbrown commented Mar 5, 2018

adrie-tc commented Mar 6, 2018

ghost commented Apr 5, 2018

alexmannuk commented Aug 24, 2020

ssddanbrown commented May 4, 2021

PDF Export issue #392

PDF Export issue #392

Comments

Dav31 commented May 11, 2017

ssddanbrown commented May 28, 2017

Dav31 commented May 29, 2017

the4ndy commented May 31, 2017

vladime commented Aug 4, 2017

Alwaysin commented Aug 4, 2017

pabloalbrecht commented Aug 5, 2017

ssddanbrown commented Aug 6, 2017

vladime commented Aug 6, 2017 via email

julienmmm commented Aug 21, 2017

Dav31 commented Sep 7, 2017

jacksonp2008 commented Sep 8, 2017

nblenkhorn commented Sep 11, 2017

megamorf commented Sep 12, 2017

ssddanbrown commented Sep 23, 2017

julienmmm commented Sep 23, 2017 via email

megamorf commented Sep 24, 2017

Dav31 commented Sep 25, 2017

ssddanbrown commented Oct 6, 2017

megamorf commented Oct 7, 2017

megamorf commented Oct 7, 2017 • edited Loading

Alwaysin commented Oct 8, 2017

julienmmm commented Oct 9, 2017

Dav31 commented Oct 13, 2017

aljawaid commented Nov 26, 2017

aljawaid commented Nov 29, 2017

adrie-tc commented Jan 18, 2018

adrie-tc commented Feb 20, 2018

ssddanbrown commented Mar 5, 2018

adrie-tc commented Mar 6, 2018

ghost commented Apr 5, 2018

alexmannuk commented Aug 24, 2020

ssddanbrown commented May 4, 2021

megamorf commented Oct 7, 2017 •

edited

Loading